doc_nested_refdefs: new lint for suspicious list syntax

[notriddle]

rust-lang/rust#133150

This is more likely to be intended as an intra-doc link than it is to be intended as a refdef. If a refdef is intended, it does not need to be nested within a list item.

- [`LONG_INTRA_DOC_LINK`]: this
  looks like an intra-doc link,
  but is actually a refdef.
  The first line will seem to
  disappear when rendered as HTML.

• looks like an intra-doc link,
  but is actually a refdef.
  The first line will seem to
  disappear when rendered as HTML.

changelog: [doc_nested_refdefs]: add suspicious lint for link def at start of list items and block quotes

[rustbot]

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[bors]

☔ The latest upstream changes (presumably 8298da7) made this pull request unmergeable. Please resolve the merge conflicts.

[Jarcho]

Is Tag::DefinitionList used for something other than reference definitions? You should be able to use that rather than trying to parse them.

[Jarcho]

FCP has been started: https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/FCP.20.60doc_refdef_list_item.60.

[notriddle]

Tag::DefinitionList is an unrelated syntax extension that rustdoc doesn't even enable.

[Jarcho]

A couple of little things, but otherwise looks good.

Could you also add this check to block quotes as well since they have the same issue. I would just put them under a single lint named either doc_nested_reference_definitions or doc_nested_refdefs (I don't have a preference on whether to use the shorthand).

FCP has received no objections so this should be good to go.

[Jarcho]

Tag::DefinitionList is an unrelated syntax extension that rustdoc doesn't even enable.

That's rather unfortunate that these don't show up in the parser at all.

[notriddle]

Okay, I've made both changes.

[Jarcho]

Thank you.