-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare clippy_utils
README and Cargo.toml for publishing
#13693
Prepare clippy_utils
README and Cargo.toml for publishing
#13693
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being that the first commit has a single file change, I think we can squash these two commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this! :D
<!-- begin autogenerated nightly --> | ||
``` | ||
nightly-2024-11-14 | ||
``` | ||
<!-- end autogenerated nightly --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Nit) This could be moved to be under the "Usage" section, where it is referred to. (As long as the generation script can handle that!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could, I put it here to put it as early as possible in the README.md
, so that scrolling isn't necessary to get to the version. I can change this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved it.
34220a7
to
aada4c3
Compare
- Add metadata to clippy_utils/Cargo.toml file - Add clippy_utils README.md file
aada4c3
to
74b95f2
Compare
@blyxyas Rebased on top of master, and squashed the commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! ❤️
Based on #13693 Adds 2 subcommands to `cargo dev`: - `cargo dev sync update_nightly`: Which updates the nightly versions in `rust-toolchain` and `clippy_utils/README.md` - `cargo dev release bump_version`: Bumps the version in all relevant `Cargo.toml` files Those are pulled out of #12759, which I'll rebase on this. Next step is to update the documentation, which I'll partly pull out of #12762 r? @blyxyas (as you reviewed the first PR in the chain and were assigned to the second one) cc #13556 changelog: none
Follow up to #13691
Adds metadata to the
clippy_utils/Cargo.toml
, which is mostly copied from the rootCargo.toml
.Adds a
README.md
file listing the nightly versionclippy_utils
can be used with, mentions that there are no stability guarantees and the license.The next PR will add automation to update the nightly toolchains in those files and the versions in the
Cargo.toml
s.cc #13556
changelog: none