-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't consider lifetimes in bounded types unused (fix extra_unused_lifetimes
FP)
#13583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties
label
Oct 22, 2024
smoelius
changed the title
Don't consider lifetimes in bounded types unused (fix
Don't consider lifetimes in bounded types unused (fix Oct 22, 2024
needless_lifetimes
FP #13578)extra_unused_lifetimes
FP #13578)
Alexendoo
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
auto-merge was automatically disabled
November 18, 2024 20:07
Pull request was closed
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 18, 2024
Please let me know if I should do something. |
Maybe a network error, not sure, let's try it again |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 18, 2024
Weird, maybe give it a rebase + push |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 18, 2024
changelog: don't consider lifetimes in bounded types unused (fix `extra_unused_lifetimes` FP rust-lang#13578)
smoelius
changed the title
Don't consider lifetimes in bounded types unused (fix
Don't consider lifetimes in bounded types unused (fix Nov 19, 2024
extra_unused_lifetimes
FP #13578)extra_unused_lifetimes
FP)
@Alexendoo I renamed the PR in the hope of allowing it to be merged. |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13578
r? @Alexendoo
changelog: don't consider lifetimes in bounded types unused (fix
extra_unused_lifetimes
FP #13578)