Skip to content

Commit

Permalink
add note about update-all-refs script, revert redundant pat to master
Browse files Browse the repository at this point in the history
  • Loading branch information
DevinR528 committed Mar 18, 2020
1 parent f34d1b0 commit 56b07a8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 3 additions & 1 deletion doc/adding_lints.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,9 @@ Once we are satisfied with the output, we need to run
Please note that, we should run `TESTNAME=foo_functions cargo uitest`
every time before running `tests/ui/update-all-references.sh`.
Running `TESTNAME=foo_functions cargo uitest` should pass then. When we commit
our lint, we need to commit the generated `.stderr` files, too.
our lint, we need to commit the generated `.stderr` files, too. In general you
should only run `tests/ui/update-all-references.sh` for the specific lint you are
creating/editing.

## Rustfix tests

Expand Down
1 change: 0 additions & 1 deletion tests/ui/redundant_pattern_matching.rs
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ fn main() {

let _ = does_something();
let _ = returns_unit();
let _ = issue_5271();

let opt = Some(false);
let x = if let Some(_) = opt { true } else { false };
Expand Down

0 comments on commit 56b07a8

Please sign in to comment.