Skip to content

Add start of GUI tests for clippy lints page #13

Add start of GUI tests for clippy lints page

Add start of GUI tests for clippy lints page #13

Workflow file for this run

name: Clippy Test
on:
pull_request:
env:
RUST_BACKTRACE: 1
CARGO_TARGET_DIR: '${{ github.workspace }}/target'
NO_FMT_TEST: 1
CARGO_INCREMENTAL: 0
RUSTFLAGS: -D warnings
BROWSER_UI_TEST_VERSION: '0.18.2'
concurrency:
# For a given workflow, if we push to the same PR, cancel all previous builds on that PR.
# If the push is not attached to a PR, we will cancel all builds on the same branch.
group: "${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}"
cancel-in-progress: true
jobs:

Check failure on line 20 in .github/workflows/clippy_pr.yml

View workflow run for this annotation

GitHub Actions / .github/workflows/clippy_pr.yml

Invalid workflow file

You have an error in your yaml syntax on line 20
base:
# NOTE: If you modify this job, make sure you copy the changes to clippy_mq.yml
runs-on: ubuntu-latest
steps:
# Setup
- name: Checkout
uses: actions/checkout@v4
- name: Install toolchain
run: rustup show active-toolchain
- name: Install npm
uses: actions/setup-node@v3
with:
node-version: 20
- name: Install browser-ui-test
run: npm install browser-ui-test@"${BROWSER_UI_TEST_VERSION}"
# Run
- name: Build
run: cargo build --tests --features internal
- name: Test
run: cargo test --features internal
- name: Test clippy_lints
run: cargo test --features internal
working-directory: clippy_lints
- name: Test clippy_utils
run: cargo test
working-directory: clippy_utils
- name: Test rustc_tools_util
run: cargo test
working-directory: rustc_tools_util
- name: Test clippy_dev
run: cargo test
working-directory: clippy_dev
- name: Test clippy-driver
run: .github/driver.sh
env:
OS: ${{ runner.os }}
- name: Test clippy lints page
run: cargo guitest
# We need to have the "conclusion" job also on PR CI, to make it possible
# to add PRs to a merge queue.
conclusion:
needs: [ base ]
# We need to ensure this job does *not* get skipped if its dependencies fail,
# because a skipped job is considered a success by GitHub. So we have to
# overwrite `if:`. We use `!cancelled()` to ensure the job does still not get run
# when the workflow is canceled manually.
#
# ALL THE PREVIOUS JOBS NEED TO BE ADDED TO THE `needs` SECTION OF THIS JOB!
if: ${{ !cancelled() }}
runs-on: ubuntu-latest
steps:
# Manually check the status of all dependencies. `if: failure()` does not work.
- name: Conclusion
run: |
# Print the dependent jobs to see them in the CI log
jq -C <<< '${{ toJson(needs) }}'
# Check if all jobs that we depend on (in the needs array) were successful.
jq --exit-status 'all(.result == "success")' <<< '${{ toJson(needs) }}'