Implement cargo lint and fix some clippy errors
#1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should turn it on after Iterator::copied stabilizes
matklad
reviewed
Jun 4, 2019
| @@ -334,7 +334,7 @@ fn best_action_for_target<'b, 'a: 'b>( | |||
| .filter_map(ast::UseItem::use_tree) | |||
| .map(|u| walk_use_tree_for_best_action(&mut storage, None, u, target)) | |||
| .fold(None, |best, a| { | |||
| best.and_then(|best| Some(*ImportAction::better(&best, &a))).or(Some(a)) | |||
| best.and_then(|best| Some(*ImportAction::better(&best, &a))).or_else(|| Some(a)) | |||
There was a problem hiding this comment.
I feel conflicted about this, it seems like closure creates noise for little benefit here. But I guess it's ok?
There was a problem hiding this comment.
Yeah, I think the fact that clippy interprets these constructors as "function calls" is pretty unfortunate, It looks like a bug (rust-lang/rust-clippy#1609), but for now I figured that it'd be better to make the changes just so we can get all the lint errors out of the way.
crates/ra_project_model/src/lib.rs
Outdated
| @@ -183,7 +183,7 @@ impl ProjectWorkspace { | |||
| if let (Some(&from), Some(&to)) = | |||
| (sysroot_crates.get(&from), sysroot_crates.get(&to)) | |||
| { | |||
| if let Err(_) = crate_graph.add_dep(from, name.into(), to) { | |||
There was a problem hiding this comment.
Let's disable this lint? I find if let somewhat more readable, and, with result, Err(_) also sends a strong signal that an error is ignored.
|
✌️ alanhdu can now approve this pull request |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 4, 2019
1374: Implement `cargo lint` and fix some clippy errors r=alanhdu a=alanhdu This creates a `cargo lint` command that runs clippy with certain lints disabled. I've also gone ahead and fixed some of the lint errors, although there are many more still to go. cc #848 Co-authored-by: Alan Du <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a
cargo lintcommand that runs clippy with certain lints disabled. I've also gone ahead and fixed some of the lint errors, although there are many more still to go.cc #848