Evaluate constants in array repeat expression #11112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodiebold
approved these changes
Jan 4, 2022
| // note: this may break later if we add more consteval. it just needs to be something that our | ||
| // consteval engine doesn't understand | ||
| check_assist_not_applicable( | ||
| check_assist( |
There was a problem hiding this comment.
this is supposed to test a case where the assist isn't applicable, so would you mind changing it to something else and leave the comment?
There was a problem hiding this comment.
Ah I missed the comment's point completely
|
✌️ HKalbasi can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors r+ |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #8655