Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show values of constants in hover #10933

Merged
merged 1 commit into from
Dec 23, 2021
Merged

feat: show values of constants in hover #10933

merged 1 commit into from
Dec 23, 2021

Conversation

HKalbasi
Copy link
Member

@HKalbasi HKalbasi commented Dec 4, 2021

Fix #8497
cc #8655

@HKalbasi
Copy link
Member Author

r? @flodiebold

@Veykril Veykril mentioned this pull request Dec 17, 2021
Open
@flodiebold
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Dec 23, 2021
@bors @HKalbasi
Merge #10933
d6d4827 
10933: show values of constants in hover r=flodiebold a=HKalbasi

Fix #8497
cc #8655


Co-authored-by: hkalbasi <[email protected]>
@bors
Copy link
Contributor

bors bot commented Dec 23, 2021

Build failed:

@lnicola
Copy link
Member

lnicola commented Dec 23, 2021 •
edited
Loading

Needs a rebase to pass Interner by value, but it's pretty mechanical.

@HKalbasi
Copy link
Member Author

Rebased.

@lnicola
Copy link
Member

lnicola commented Dec 23, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 23, 2021

Build succeeded:

@bors bors bot merged commit 7b7a1ed into rust-lang:master Dec 23, 2021
@lnicola lnicola changed the title show values of constants in hover feat: show values of constants in hover Dec 23, 2021
@lnicola
Copy link
Member

lnicola commented Dec 23, 2021

image

image

@mqudsi mqudsi mentioned this pull request Feb 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: show values of constants
3 participants
@HKalbasi @flodiebold @lnicola