Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

feat: update lsp_types to the latest version #1778

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Jun 11, 2022

  • feat: update lsp_types to the latest version:
    • This required adding some optional fields
    • Updating the progress reporter
    • Using u32 in some places instead of u64
    • Passing the correct type as the request/response
    • Changing the enum field cases to upper case

After debugging the code for some time, I cannot find the reason why the 9 remaining tests are failing. Any help would be appreciated.

using this in the find_impls test seems to fix the issue, but modifying the tests like this looks random to me.

                work_done_progress_params: WorkDoneProgressParams {
                    work_done_token: Some(NumberOrString::String("progress_1".to_owned())),
                },

cc: @Xanewok

@bors
Copy link
Contributor

bors commented Jun 25, 2022

☔ The latest upstream changes (presumably ece09b8) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants