Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Make Cargo respect minimum supported Rust version (MSRV) when selecting dependencies #3537

Merged
merged 184 commits into from
Feb 28, 2024
Merged
Changes from 120 commits
Commits
Show all changes
184 commits
Select commit Hold shift + click to select a range
fb56964
chore: Add skeleton
epage Nov 14, 2023
b41b342
feat: Initial draft
epage Nov 14, 2023
2ace3a0
fix: Add missing connector statement
epage Nov 15, 2023
42b6853
fix: Clarify the stagnation drawback
epage Nov 15, 2023
993f52f
feat: Acknowledge CI incompatibility change
epage Nov 15, 2023
404ec9a
feat: Acknowledge desire to set msrv more
epage Nov 15, 2023
b757cb7
feat: Cover workspace.rust-version
epage Nov 15, 2023
2da8375
fix: Expand on implicit MSRV
epage Nov 15, 2023
72f7bef
fix: Be more explicit about rustc fallback
epage Nov 15, 2023
44c28b4
fix: Add another design consideration
epage Nov 15, 2023
f663bf2
feat: Add 'rustc --version' fallback to proposal
epage Nov 15, 2023
2fc50a2
fix: Small language clarifications
epage Nov 17, 2023
01feadc
fix: Minor cleanup
epage Nov 28, 2023
4547449
feat: Add Guide
epage Nov 28, 2023
6a704c9
feat: Update proposal for new config
epage Nov 28, 2023
f534b34
fix: Typo
epage Nov 28, 2023
e794db9
fix: Cover why we use config
epage Nov 28, 2023
9a2b85c
fix: Make explicit that feature-specific MSRVs can still work
epage Nov 28, 2023
5a10cd6
fix: Mention the backtracking trade off
epage Nov 28, 2023
260ef18
fix: Mention rustup MSRV support
epage Nov 28, 2023
ac35d97
fix: Cover cargo-unrelated MSRV improvements
epage Nov 28, 2023
ac9aef6
fix: Mention Python's support window
epage Nov 29, 2023
6d85ec9
fix: Add PreRFC link
epage Nov 29, 2023
66c04c0
fix: Add RFC number
epage Nov 29, 2023
736060a
feat: Acknowledge a role in MSRV policy setting
epage Nov 29, 2023
6de5f4d
fix: Clarify wording
epage Nov 29, 2023
76d2f98
fix: Update future possibility for config change
epage Nov 29, 2023
c668698
fix: Simplify config
epage Nov 29, 2023
3015bd3
fix: Typos
epage Nov 29, 2023
2db39c0
fix: Typo
epage Nov 29, 2023
5c55bd1
fix: Separate top-level selection from deps clearer
epage Nov 29, 2023
4fc3608
fix: Extend future possibility with rust-version-policy field
epage Nov 29, 2023
0228ae7
fix: Typo
epage Nov 30, 2023
d418634
fix: Typo
epage Nov 30, 2023
8eaf4dd
fix: Actually make sense when discussing precedence without MSRV set
epage Nov 30, 2023
e54af30
fix: Call out rust-toolchain.toml
epage Nov 30, 2023
5b6b306
fix: Update stale references for proposed config
epage Nov 30, 2023
413ee13
fix: Call out use of 'cargo update' for CI
epage Nov 30, 2023
974f233
fix: Be consistent when naming MSRV workflows
epage Nov 30, 2023
b5d0cef
fix: Clarify and define workflow terms
epage Nov 30, 2023
4deef7f
fix: Use existing issue for tracking issue
epage Nov 30, 2023
065c97f
fix: Talk through more extensive reporting
epage Dec 5, 2023
66ee8bf
feat: Provide examples for why people are on old versions
epage Dec 7, 2023
1d507f1
fix: Capture matklad's feedback on testing latest deps
epage Dec 7, 2023
538167b
fix: Shift most of the CI discussion from Alt to Drawback
epage Dec 7, 2023
3419057
fix: Add another old-MSRV reason
epage Dec 7, 2023
f597ea3
refactor: Make most pertinent alternatives more obvious
epage Dec 7, 2023
05d86e4
fix: Try to clarify the multi-MSRV situations
epage Dec 7, 2023
c60d85e
fix: Call out hard-error's problem with feature-dependent MSRV
epage Dec 7, 2023
98db27a
fix: Cover rust-toolchain file
epage Dec 7, 2023
fc0d66e
fix: Apply feedback to 'resolve with rustc version'
epage Dec 7, 2023
593d56d
feat: Define 'support'
epage Dec 7, 2023
8f0c0cf
feat: Add PHP prior art
epage Dec 12, 2023
1514401
fix: Clarify misc section
epage Dec 14, 2023
b268e45
Be explicit about impact for verifying latest dependencies
epage Dec 14, 2023
ff544c4
fix: Emphasize, rather than yellow
epage Dec 14, 2023
447048d
feat: Expand on opt-in
epage Dec 12, 2023
ca225b9
rustc
epage Dec 14, 2023
2381b9d
fix: Clarify the fallback to rustc --version
epage Dec 15, 2023
c874e2b
fix: Clear up language on cargo config
epage Dec 15, 2023
f4cb627
fix: Clarify the scope of a drawback
epage Dec 15, 2023
f2c1e86
fix: Soften unintentionally strong language on minor bumps
epage Dec 15, 2023
94b0bf3
fix: Clarify why minor is suggested
epage Dec 15, 2023
df3f275
fix: Remove reason against tying to edition
epage Dec 15, 2023
6f1e52a
fix: Clarify role of CI
epage Dec 15, 2023
718a15a
fix: Make a sentence a little less redundant
epage Jan 3, 2024
914d764
refactor(motivation): Re-center on common workflows
epage Jan 7, 2024
2a768c9
fix(motivation): Call out role of rust-toolchain.toml file
epage Jan 8, 2024
6addf93
fix(motivation): Cover verifying multiple versions
epage Jan 8, 2024
4e7c0d0
fix(motivation): Don't have two workflows at same priority
epage Jan 8, 2024
d8bcc36
fix(motivation): Clarify the structure
epage Jan 10, 2024
6d15b97
fix(motivation): Minor expansion on MSRV workarounds
epage Jan 10, 2024
a6bd027
fix(motivation): Clarify and expand on workflows
epage Jan 10, 2024
f99ecac
fix(ref): Call out stabilization plan
epage Jan 10, 2024
f1cb6bf
feat(ref): Tie the solution to an Edition
epage Jan 10, 2024
541580c
feat(ref): Add perma-setting for '--ignore-rust-version' for builds
epage Jan 11, 2024
ca32ebc
feat(ref): Add '--update-rust-version' to help users 'progress'
epage Jan 11, 2024
e44a724
feat(ref): Add 'rust-version=auto'
epage Jan 11, 2024
941b0a3
refactor(rationale): Re-order sections
epage Jan 11, 2024
4e0a359
fix(unresolved): Add another alt for config field
epage Jan 11, 2024
2f709d6
fix(future): Clarify why cargo-audit
epage Jan 11, 2024
d52fdb3
refactor(rationale): Re-work resolver discussion around workflows
epage Jan 11, 2024
8a6bc9b
fix(motivation): Better balance stagnation-avoidance
epage Jan 11, 2024
12eb56f
fix(motivation): Soften language to not shame bugs
epage Jan 11, 2024
2504124
fix(motivation): Clarify that lockfile changes are restricted to dep …
epage Jan 11, 2024
2365d6f
fix(motivation): Grammar
epage Jan 11, 2024
5a8ed3d
fix(motivation): Call out dependent impact on no-msrv
epage Jan 11, 2024
165d447
fix(motivation): Clarify toolchain problem with latest msrv
epage Jan 11, 2024
a98f54a
fix(motivation): Add list separator
epage Jan 12, 2024
c2b70e5
fix(motivation): Re-order principles to soften it
epage Jan 12, 2024
b28ffd2
fix(motivation): Soften costs talk
epage Jan 12, 2024
c5a7d63
fix(motivation): Bridge global MSRV to exceptions
epage Jan 12, 2024
f390368
fix(motivation): Typo
epage Jan 12, 2024
ba2acae
fix(motivation): Clarify dev-dependencies workflow
epage Jan 12, 2024
9b119eb
fix(ref): Soften language on cargo-update
epage Jan 12, 2024
eebb556
fix(ref): Clarify reasoning for behavior
epage Jan 12, 2024
62a217f
fix(ref): Soften cargo-add language
epage Jan 12, 2024
a886c92
fix(ref): Move config by resolver
epage Jan 12, 2024
330eee4
fix(ref): Update config section
epage Jan 12, 2024
590e085
fix(rationale): Add more to why aggressive MSRV is fine
epage Jan 12, 2024
e2128c4
fix(rationale): Clean up grammar
epage Jan 12, 2024
8171e5f
fix(rationale): Clarify why config is still needed
epage Jan 12, 2024
037300b
fix(rationale): Clean up alternative comparison
epage Jan 12, 2024
7cf62af
fix(ref): Flatten the config
epage Jan 12, 2024
d54dbb1
fix(future): 1.75 is now past tense
epage Jan 12, 2024
1eca864
fix(motivation): Transfer use cases to priority description
epage Jan 13, 2024
fdb539f
style(alt): Line wrap paragraph
epage Jan 15, 2024
4e269a5
feat(alt): Expand on rust-version-policy
epage Jan 15, 2024
e87c4be
feat(future): Include cargo-publish issue
epage Jan 16, 2024
3990895
fix: Typo
epage Jan 19, 2024
9e76b7c
fix(ref): Be more specific on auto behavior
epage Jan 19, 2024
351ec04
feat(ref): Mirror new 'update' flags on 'generate-lockfile'
epage Jan 19, 2024
9b592cb
fix(alt): Clarify reporting's tree change meaning
epage Jan 19, 2024
3108268
fix(alt): Cover Reporting for no Cargo.lock
epage Jan 19, 2024
b1b8f2b
fix(unresolved): Call out reporting level for stabilization process
epage Jan 19, 2024
5efca85
fix(ref): Be more explicit about auto behavior
epage Jan 20, 2024
7f9355a
fix(guide): Clean up language in config docs
epage Jan 20, 2024
8d083f8
fix(guide): Fix direction of comparison
epage Jan 20, 2024
8753df1
fix(ref): Be explicit that old dependencies are preferred
epage Jan 20, 2024
40e9374
fix(summary): Call out the MSRV data help
epage Jan 20, 2024
1c66807
fix(ref): Be more explicit on update behavior
epage Jan 22, 2024
5b360f9
feat(deferred): Defer resolving `auto`s name
epage Jan 23, 2024
bb90a15
fix(deferred): Expand on config
epage Jan 23, 2024
ce36cf2
feat(rationale): Discuss --ignore-rust-version and compilation
epage Jan 23, 2024
c44a063
fix(alt): Typo
epage Jan 23, 2024
ee1f87e
fix(guide): Split out documentation updates section
epage Jan 23, 2024
6b06734
fix(future): Maybe caution about unspecified MSRVs?
epage Jan 23, 2024
505224a
fix(ref): Nightly publish with auto should warn
epage Jan 23, 2024
6c17440
fix(ref): Improve compilation diagnostic
epage Jan 24, 2024
0bc42a8
fix(ref): Promote report on every command from alt to ref, but keep i…
epage Jan 24, 2024
242bc19
feat(guide): Step through this RFC with different users/workflows
epage Jan 24, 2024
18a2683
fix(motivation): Tweak lockfile language
epage Jan 24, 2024
9e2641d
fix: Correct suggested rustup command
epage Feb 2, 2024
c68b072
fix: Remove extra word
epage Feb 2, 2024
6458c0c
fix: Clarify -n is dry-run
epage Feb 2, 2024
3ee143a
fix: Clarify 'we' in pain points
epage Feb 2, 2024
064fdac
fix(ref): Clarify transition for reporting stale dependencies
epage Feb 2, 2024
7c30483
fix(guide): Include auto in documentation update
epage Feb 2, 2024
30049fe
fix(motivation): Add status quo header
epage Feb 2, 2024
7b84264
fix(ref): Remove stale comment
epage Feb 2, 2024
1244f87
fix(ref): Clarify held-back reporting
epage Feb 2, 2024
aae359c
fix(ref): Clarify rust-version statement
epage Feb 2, 2024
9b9390e
fix(drawback): Remind people about limtis of workspace.resolver warning
epage Feb 2, 2024
ec79f52
fix(rationale): Remove stale rationale
epage Feb 2, 2024
1dab410
fix(rationale): Clarify rust-version and minimal version interaction
epage Feb 2, 2024
43db971
fix(rationale): Clarify rust-version and minimal version interaction
epage Feb 2, 2024
5294aba
fix(rationale): Clarify workspace-level lint for incompatible MSRV
epage Feb 2, 2024
382cb1d
fix(rationale): Switch how we highlight different cases for ignore-ru…
epage Feb 2, 2024
7542afc
fix(rationale): Clarify sentence for update-rust-version
epage Feb 2, 2024
1896b00
fix(rationale): Clarify section on auto
epage Feb 2, 2024
fda1f88
fix(guide): Collapse workflow step throughs
epage Feb 8, 2024
da29fce
fix(ref): Switch nightly auto to unset on publish
epage Feb 8, 2024
1a97aef
refactor(guide): Move example workflows later
epage Feb 8, 2024
14dc48b
fix(guide): Clean up rust-version documentation
epage Feb 8, 2024
3923454
fix(guide): Add a summary
epage Feb 8, 2024
040a981
fix(motivation): Highlight which are pros and cons
epage Feb 15, 2024
d08e04f
fix(ref): Add missing context for resolve diffing
epage Feb 15, 2024
9977612
fix(ref): Specify rust-version fallback when on pre-release
epage Feb 15, 2024
cf4651b
fix(alt): Clarify why a CLI option isn't used
epage Feb 15, 2024
13fcb24
fix(alt): Further clarify CLI option
epage Feb 15, 2024
ef57daa
fix: Space out code fences
epage Feb 15, 2024
dce5d7c
fix(motivation): Include rust-version proliferation stats
epage Feb 20, 2024
abd9a5e
fix(motivation): Clarify scope of MSRV meaning
epage Feb 23, 2024
2ddb847
fix: Yeet the term 'auto' to avoid confusion
epage Feb 23, 2024
74651c9
fix(motivation): Make sure we call out security explicitly
epage Feb 23, 2024
a33ea45
fix(rationale): Include short-term benefit of polyfills
epage Feb 23, 2024
ff7d7ae
fix: Don't confuse markdown parsers treating items like HTML
epage Feb 23, 2024
895545c
feat(future): Call out tracking of maintenance status
epage Feb 23, 2024
426757f
fix(guide): Remove reference to MSRV is 'can be compiled'
epage Feb 23, 2024
9f22fbc
fix: Typo
epage Feb 27, 2024
03431f9
fix: Typo
epage Feb 27, 2024
20c2bbf
fix: Typo
epage Feb 27, 2024
5379658
fix: Typo
epage Feb 27, 2024
551b739
fix: Typo
epage Feb 27, 2024
55ca765
fix: Minor wording change
epage Feb 27, 2024
1529093
fix: Typo
epage Feb 27, 2024
d20e3ee
fix: Typo
epage Feb 27, 2024
0de0ccd
fix: Typo
epage Feb 27, 2024
08015f3
fix: Typo
epage Feb 27, 2024
fef356e
fix: Typo
epage Feb 27, 2024
7c9f7fc
fix: Typo
epage Feb 27, 2024
a8a3c1e
fix: Clarify language
epage Feb 27, 2024
16912fe
fix: Clarify language
epage Feb 27, 2024
b2947e3
feat(summary): Remind people of RFC fluidity
epage Feb 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading