-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spec Identifier Syntax to expressions.md and subchapters #1591
Merged
ehuss
merged 17 commits into
rust-lang:master
from
chorman0773:spec-add-identifiers-exprs
Jan 31, 2025
Merged
Add Spec Identifier Syntax to expressions.md and subchapters #1591
ehuss
merged 17 commits into
rust-lang:master
from
chorman0773:spec-add-identifiers-exprs
Jan 31, 2025
+623
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chorman0773
added
S-waiting-on-review
Status: The marked PR is awaiting review from a maintainer
T-spec
Team: spec
labels
Aug 27, 2024
90 tasks
traviscross
reviewed
Aug 27, 2024
traviscross
previously requested changes
Oct 18, 2024
This comment has been minimized.
This comment has been minimized.
@rustbot ready |
This comment has been minimized.
This comment has been minimized.
…xpr, tuple-expr, and underscore-expr
Co-authored-by: Travis Cross <[email protected]>
This adjusts some rule names to be more explicit about what they are for.
ehuss
force-pushed
the
spec-add-identifiers-exprs
branch
from
January 31, 2025 03:40
da42d7c
to
3e57a06
Compare
ehuss
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I really appreciate all the work you put into this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds identifier syntax to
expressions.md
and all subchapters.