Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve trait object doc #1443

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wiseaidev
Copy link

Related to #392

@wiseaidev wiseaidev marked this pull request as draft December 28, 2023 17:31
@traviscross
Copy link
Contributor

traviscross commented Jul 9, 2024

@wiseaidev: We notice this is still a draft PR. Do you still plan to move this forward?

In skimming the draft, this seems to add a lot of examples. While we like examples, this is probably too many.

There's also some language that maybe tries a bit too hard to sell the language. E.g. "is a powerful concept", and similar.

We're also a bit unclear about where the confusion is that's motivating this work. Perhaps you could explain better here, in the PR description what the motivation is, and what the nature of the confusion is that you're trying to resolve with these changes.

@ehuss ehuss added the S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Jul 16, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 3, 2024

☔ The latest upstream changes (possibly bf115a4) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants