Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add weak memory consistency test for mixing SC accesses and fences #4080

Merged
merged 1 commit into from
Dec 7, 2024
Merged

add weak memory consistency test for mixing SC accesses and fences #4080

merged 1 commit into from
Dec 7, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Dec 7, 2024

@cbeuw I could not find any existing test covering this. Did I miss something?

cbeuw
cbeuw approved these changes Dec 7, 2024
View reviewed changes
Copy link
Contributor

@cbeuw cbeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only added test cases that I found in papers and didn't come up with my own ones. So yeah there weren't any tests with both SC fences and accesses

@RalfJung RalfJung enabled auto-merge December 7, 2024 17:23
@RalfJung RalfJung added this pull request to the merge queue Dec 7, 2024
Merged via the queue into rust-lang:master with commit 35b6409 Dec 7, 2024
7 checks passed
@RalfJung RalfJung deleted the sc-fence-access-test branch December 7, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbeuw cbeuw cbeuw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RalfJung @cbeuw