Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to actions/checkout@v4 in ci.yml. #3511

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

obi1kenobi
Copy link
Member

This is a newer version of the same action. None of the uses here were particularly special (no complex features of v3 were used) so this is a straightforward as-is upgrade.

This is a newer version of the same action. None of the uses here were particularly special (no complex features of v3 were used) so this is a straightforward as-is upgrade.
@RalfJung
Copy link
Member

Thanks! I don't understand why github makes everyone do this every other year or so... oh well.

@bors r+

@bors
Copy link
Contributor

bors commented Apr 24, 2024

📌 Commit 743ab27 has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 24, 2024

⌛ Testing commit 743ab27 with merge e6914bb...

@obi1kenobi
Copy link
Member Author

There's technically a breaking change between v3 and v4, just one that affects very few use cases in practice. So I think they did the right thing, even though it's a bit annoying that almost everyone has to actively upgrade even though they aren't affected.

Btw, GitHub's Dependabot can keep actions updated to the latest versions -- I have that configured in cargo-semver-checks and it's worked well so far. If you'd like, I'd be happy to add a similar config here: once a week, it will open PRs with any upgraded actions versions that are available.

@RalfJung
Copy link
Member

Thanks! I think we'll wait for other rust-lang projects to do something like that before considering it.

@obi1kenobi
Copy link
Member Author

Makes sense. Open offer, ping me anytime if you or someone in another rust-lang project wants to try it. Happy to help.

@bors
Copy link
Contributor

bors commented Apr 24, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing e6914bb to master...

@bors bors merged commit e6914bb into rust-lang:master Apr 24, 2024
8 checks passed
@obi1kenobi obi1kenobi deleted the patch-1 branch April 24, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants