Make mmap not use expose semantics #3220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Dec 17, 2023
saethlin
force-pushed
the
strict-mmap
branch
from
cfe3684 to
def5f39
Compare
RalfJung
reviewed
Dec 17, 2023
| } | ||
|
|
||
| let len = Size::from_bytes(alloc.len() as u64); | ||
| let length = Size::from_bytes(round_to_next_multiple_of(length, this.machine.page_size)); | ||
| this.deallocate_ptr( |
There was a problem hiding this comment.
Given that there was quite a bit of discussion that led to this implementation, please add a comment explaining that.
There was a problem hiding this comment.
Good point. I've updated the comment at the top of the module, and also nuked the test that was checking for this. Does that cover your request, or should there be more explanation in munmap itself?
There was a problem hiding this comment.
I force-pushed to fix the failing tests and didn't comment. So I'm commenting now.
saethlin
force-pushed
the
strict-mmap
branch
from
def5f39 to
7176fa2
Compare
saethlin
force-pushed
the
strict-mmap
branch
from
7176fa2 to
ee50c15
Compare
|
Looks good, thanks. :) |
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3041 per #3041 (comment)