Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI should detect when breaking changes are introduced #618

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Feb 27, 2024

Note that this uses a separate semver job - which may be an overkill - perhaps it should be added to the clippy job? I wouldn't want it to compile so many times in different VMs unless needed.

See https://github.com/obi1kenobi/cargo-semver-checks?tab=readme-ov-file#quick-start

Note that this uses a separate semver job - which may be an overkill - perhaps it should be added to the clippy job?  I wouldn't want it to compile so many times in different VMs unless needed.

See https://github.com/obi1kenobi/cargo-semver-checks?tab=readme-ov-file#quick-start
@KodrAus
Copy link
Contributor

KodrAus commented Feb 28, 2024

Thanks for the PR @nyurik! This seems like something worth doing going forwards. Would you be happy to port this to using cargo-semver-checks directly with cargo install rather than through the cargo-semver-checks-action GitHub action? That way we have a clearer idea of what each job is doing and what actions we're depending on. The tool itself looks good to me 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants