-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: iai-callgrind #444
Closed
tgross35
wants to merge
18
commits into
rust-lang:tgross35/domain-multiple-dimensions
from
tgross35:icount-benchmarks
Closed
WIP: iai-callgrind #444
tgross35
wants to merge
18
commits into
rust-lang:tgross35/domain-multiple-dimensions
from
tgross35:icount-benchmarks
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
icount-benchmarks
branch
from
January 14, 2025 10:37
9278793
to
0b0d325
Compare
tgross35
changed the base branch from
master
to
tgross35/domain-multiple-dimensions
January 14, 2025 10:37
tgross35
force-pushed
the
tgross35/domain-multiple-dimensions
branch
from
January 14, 2025 12:05
591310a
to
9b09253
Compare
tgross35
force-pushed
the
icount-benchmarks
branch
from
January 14, 2025 12:06
372ffc9
to
2ca184f
Compare
tgross35
force-pushed
the
tgross35/domain-multiple-dimensions
branch
from
January 15, 2025 07:48
9b09253
to
e930f6f
Compare
tgross35
force-pushed
the
icount-benchmarks
branch
from
January 15, 2025 07:50
de28668
to
59d55fc
Compare
This reverts commit 2b8045a.
I am having some trouble getting the job to fail based on regressions, it seems like iai is not exiting with error status. Opened iai-callgrind/iai-callgrind#337, worst case I can probably parse this from JSON output. |
GH broke my branches, reopened as #447. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/iai-callgrind/iai-callgrind