Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux SCTP support part 2 (revival) #4204

Conversation

gnaaman-dn
Copy link

@gnaaman-dn gnaaman-dn commented Dec 17, 2024

Description

Revival of #3117
Adds SCTP structs and constants.

Changes from original PR:

Sources

https://github.com/torvalds/linux/blob/master/include/uapi/linux/sctp.h

https://man7.org/linux/man-pages/man7/sctp.7.html

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@gnaaman-dn gnaaman-dn marked this pull request as draft December 17, 2024 17:55
@gnaaman-dn gnaaman-dn marked this pull request as ready for review December 17, 2024 18:07
@gnaaman-dn gnaaman-dn force-pushed the gnaaman/linux_sctp2_now_with_attachment branch from 6fbf3ab to 47b9056 Compare December 17, 2024 18:20
@gnaaman-dn
Copy link
Author

Apologies for multiple pushes, I wasn't aware that --autosquash doesn't do anything without -i

@gnaaman-dn
Copy link
Author

Powepc seems to die to SIGILL, but it passes locally when running the same suite:

Caused by:
  process didn't exit successfully: `qemu-ppc -L /usr/powerpc-linux-gnu /checkout/target/powerpc-unknown-linux-gnu/debug/deps/main-00ed33f9c2abd801` (signal: 4, SIGILL: illegal instruction)

Locally:
image


Anyone encountered this?

@gnaaman-dn gnaaman-dn force-pushed the gnaaman/linux_sctp2_now_with_attachment branch from 47b9056 to 8323541 Compare December 19, 2024 07:08
@gnaaman-dn
Copy link
Author

Sorry, no idea how to debug this PPC issue.

@gnaaman-dn gnaaman-dn closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants