Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.2: Backport c_char fixes #4203

Closed
wants to merge 4 commits into from

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Dec 17, 2024

Description

Backports the following to libc-0.2:

4200 is not actually c_char-related PR, but 4202 depend on import change made in 4200.

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

SergioGasquez and others added 4 commits December 17, 2024 21:35
Create a module providing the same definitions of `c_char` as in
`rust-lang/rust`, which in most cases are based on the architecture
rather than the OS. This will allow individual platforms to reexport the
definition rather than having configuration repeated in numerous
modules.
@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35
Copy link
Contributor

The relevant pulls are included in #4206 so I will close this. Fyi I always cherry pick with xe so the commits get crosslinked and the changelog generator (sometimes) picks up the original PRs.

@tgross35 tgross35 closed this Dec 18, 2024
@taiki-e taiki-e deleted the libc-0.2-c-char branch December 18, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants