[0.2] ci: Naming adjustments and cleanup #4126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 59a18de("ci: Set `-u` (error on unset)..."), `-u` started being passed to the `set` call in shell scripts. This broke the `FILTER` logic since now the command always fails. Make this a bit less fragile by explicitly setting to an empty string, as well as adding a check that at least one test got run. (backport <rust-lang#4125>) (cherry picked from commit 084f370)
(backport <rust-lang#4125>) (cherry picked from commit 907c6d6)
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
We no longer have two separate workflows, so rename `full_ci` to just `ci`. Additionally, `.yaml` is the preferred extension [1], so rename the other `.yml` file to `.yaml`. [1]: https://yaml.org/faq.html (backport <rust-lang#4124>) (cherry picked from commit 4c96512)
The scripts say how they should execute, there isn't any reason to duplicate this wherever they are called. (backport <rust-lang#4124>) (cherry picked from commit 4707c5d)
(backport <rust-lang#4124>) (cherry picked from commit 58265b9)
This cleans things up and allows us to pass more flags externally. (backport <rust-lang#4124>) (cherry picked from commit 67988b7)
(backport <rust-lang#4124>) (cherry picked from commit bbf941b)
(backport <rust-lang#4124>) (cherry picked from commit c90236b)
(backport <rust-lang#4124>) (cherry picked from commit 3faaf4d)
The Mac, Windows, and Linux jobs for build channels are pretty redundant. Turn this into a single `verify_build` job that has both OS and version in its matrix. For consistency, rename the script to `verify-build`. To simplify variables, allow the build and toolchain scripts to detect the OS rather than passing it from CI. (backport <rust-lang#4124>) (cherry picked from commit c4e3ff8)
The Mac, Windows, and Linux jobs for testing are pretty redundant. Turn this into a single `test_tier1` job that runs all expected combinations. (backport <rust-lang#4124>) (cherry picked from commit 01244c5)
(backport <rust-lang#4124>) (cherry picked from commit 33582fc)
Solaris is a Tier 2 target so defer it until after tier1 completes. We currently do this for the other T2 targets. In preparation of adding other VM tests to the matrix, adjust naming. Additionally, just `set -x` rather than priting the commands before running them. (backport <rust-lang#4124>) (cherry picked from commit 549eb77)
(backport <rust-lang#4124>) (cherry picked from commit 09a2bcf)
(backport <rust-lang#4124>) (cherry picked from commit 0892b44)
tgross35
force-pushed
the
backport-ci-naming
branch
from
64252ec to
7a897dd
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport the following: