-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows stats::st_mode
and stat
flags type.
#3625
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
☔ The latest upstream changes (presumably #3631) made this pull request unmergeable. Please resolve the merge conflicts. |
src/windows/mod.rs
Outdated
pub const S_IFCHR: ::c_ushort = 8192; | ||
pub const S_IFDIR: ::c_ushort = 16384; | ||
pub const S_IFREG: ::c_ushort = 32768; | ||
pub const S_IFMT: ::c_ushort = 61440; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some unnecessary spaces here
Hi, I am the one who is working on the project to modernize the libc crate (Related: GSoC Idea GSoC Zulip). |
This seems reasonable for a breaking change: relevant source is at https://github.com/microsoft/win32metadata/blob/9bde55b65e3ed63b0473c47c1ef1c5d359c48945/generation/WinSDK/RecompiledIdlHeaders/ucrt/sys/stat.h#L91, Amanieu approved already. @Lilit0x please rebase then this should be good to go. |
Please run @rustbot author |
Bit flags are commonly expressed in octal or hexadecimal. Is there any reason to change to decimal here? Using hex would make it easier to confirm that the values are equivalent to other files that define these bitmasks. |
@Lilit0x ping, would you be able to update this? |
b5d2254
to
b56d275
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lilit0x I pushed to your branch to do the rebase and change these back to octal
Synchronized the types of the
st_mode
property of thestat
struct and the flags of thestat
header file.Fixes #3161