Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows stats::st_mode and stat flags type. #3625

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

Lilit0x
Copy link
Contributor

@Lilit0x Lilit0x commented Mar 17, 2024

Synchronized the types of the st_mode property of the stat struct and the flags of the stat header file.

Fixes #3161

@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@bors
Copy link
Contributor

bors commented Apr 26, 2024

☔ The latest upstream changes (presumably #3631) made this pull request unmergeable. Please resolve the merge conflicts.

pub const S_IFCHR: ::c_ushort = 8192;
pub const S_IFDIR: ::c_ushort = 16384;
pub const S_IFREG: ::c_ushort = 32768;
pub const S_IFMT: ::c_ushort = 61440;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some unnecessary spaces here

@myl7
Copy link

myl7 commented Aug 5, 2024

Hi, I am the one who is working on the project to modernize the libc crate (Related: GSoC Idea GSoC Zulip).
I would like to ask that if I could rebase your commits to help merge them?

@tgross35
Copy link
Contributor

This seems reasonable for a breaking change: relevant source is at https://github.com/microsoft/win32metadata/blob/9bde55b65e3ed63b0473c47c1ef1c5d359c48945/generation/WinSDK/RecompiledIdlHeaders/ucrt/sys/stat.h#L91, Amanieu approved already.

@Lilit0x please rebase then this should be good to go.

@tgross35
Copy link
Contributor

tgross35 commented Aug 14, 2024

Please run cargo fmt, then rebase and squash (to drop the merge commit)

@rustbot author

@jongiddy
Copy link

Bit flags are commonly expressed in octal or hexadecimal. Is there any reason to change to decimal here? Using hex would make it easier to confirm that the values are equivalent to other files that define these bitmasks.

@tgross35
Copy link
Contributor

@Lilit0x ping, would you be able to update this?

@tgross35 tgross35 force-pushed the stat-flags-and-mode-type branch from b5d2254 to b56d275 Compare November 20, 2024 21:16
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lilit0x I pushed to your branch to do the rebase and change these back to octal

@tgross35 tgross35 enabled auto-merge November 20, 2024 21:20
@tgross35 tgross35 added the stable-declined This change is breaking, difficult to backport, low priority, or otherwise not relevant for 0.2 label Nov 20, 2024
@tgross35 tgross35 added this pull request to the merge queue Nov 20, 2024
Merged via the queue into rust-lang:main with commit 117d6b0 Nov 20, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakage-candidate O-windows S-waiting-on-author stable-declined This change is breaking, difficult to backport, low priority, or otherwise not relevant for 0.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windows: stat::st_mode and S_IFMT are of different type
9 participants