Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup and update the project #46

Merged
merged 8 commits into from
Mar 30, 2024
Merged

Cleanup and update the project #46

merged 8 commits into from
Mar 30, 2024

Conversation

BD103
Copy link
Contributor

@BD103 BD103 commented Jan 11, 2024 •
edited
Loading

This adds a few smaller changes that makes ferris-says less dated.

  • Migrates the base crate to the 2021 edition (3126457)
  • Fix incorrect version in the readme (ee49038)
  • Update examples in readme and doctests (898bdf7, c7486f0)
  • Additional formatting
  • Raise minimum required version of dependencies

BD103 added 6 commits January 10, 2024 17:56
@BD103
feat(ferris-says): migrate to 2021 edition
3126457
@BD103
refactor: format imports and comments
c6672b6
@BD103
fix: update version in readme
ee49038 
Additionally add information to automatically install the latest version of ferris-says using cargo-add.

Almost directly taken from #44.
@BD103
chore: update example in readme
898bdf7 
Partially inspired by #44.
@BD103
refactor(ferris-says): format doctest
c7486f0
@BD103
deps(ferris-says): bump dependencies
21ef72c 
None of the new versions introduce breaking changes, so it's safe to require a higher minimum.
@BD103
Copy link
Contributor Author

BD103 commented Jan 11, 2024

@Amanieu would you mind reviewing this PR? If not, I can ping someone else on the crate-maintainers teams.

@Amanieu
Copy link
Member

Amanieu commented Mar 29, 2024

r? @lcnr

@lcnr
Copy link
Contributor

lcnr commented Mar 30, 2024

Thank you for splitting your PR in self-contained commits, I very much appreciate it. ❤️

Your PR currently has merge conflicts and some of the commits are now unnecessary. It unfortunately needs a rebase.

@BD103
Copy link
Contributor Author

BD103 commented Mar 30, 2024

Thank you for splitting your PR in self-contained commits, I very much appreciate it. ❤️

Your PR currently has merge conflicts and some of the commits are now unnecessary. It unfortunately needs a rebase.

Ok, merge conflicts resolved! :)

@lcnr
Copy link
Contributor

lcnr commented Mar 30, 2024

Thanks!

@lcnr lcnr merged commit ee28135 into rust-lang:main Mar 30, 2024
5 checks passed
@lcnr lcnr mentioned this pull request Mar 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BD103 @Amanieu @lcnr