fix build-details view for pre-build errors, when another build set the default target #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
syphar
force-pushed
the
fix-build-details
branch
from
210e150 to
7c760fe
Compare
…he default target
syphar
force-pushed
the
fix-build-details
branch
from
7c760fe to
017469d
Compare
GuillaumeGomez
approved these changes
Dec 6, 2024
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when looking at https://docs.rs/crate/defmt/0.3.9/builds/
we see that we can't access the older builds, even though that worked at some point.
Reason is that we correctly don't have a build log for these, because they failed before starting the build, but the fallback logic trying to use the default target, if given, lead to a "resource not found" error, while we can show the pre-build error instead of the log.
see also #2679