Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use crate name normalization when trying to delete crates / releases #2620

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

syphar
Copy link
Member

@syphar syphar commented Sep 28, 2024

There was a case with a crate called Horizon_Data_Types, which then was deleted on crate.io (I assume via support request).

Interestingly we had the crate in our db as Horizon_Data_Types, while the delete change from the crates.io index came as horizon_data_types. That delete-request then failed because we didn't find the name.
See https://rust-lang.sentry.io/issues/5128144333/?environment=production&project=5499376&query=&referrer=issue-stream&statsPeriod=90d&stream_index=4

The following build of the same crate as a new crate with a different name (horizon-data-types) then lead to a conflict error because we check uniqueness of crate names after normalization.
Error: https://rust-lang.sentry.io/issues/5913176075/?environment=production&project=5499376&query=&referrer=issue-stream&statsPeriod=90d&stream_index=1

This change will use normalization when handling deletes.

@syphar syphar requested a review from a team as a code owner September 28, 2024 11:50
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Sep 28, 2024
@syphar syphar force-pushed the crate-delete-normalize branch from fe4e5ca to 6425322 Compare September 28, 2024 11:55
@syphar syphar merged commit 41d5e31 into rust-lang:master Sep 28, 2024
9 checks passed
@syphar syphar deleted the crate-delete-normalize branch September 28, 2024 19:03
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Sep 28, 2024
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants