fix initial migration that should not include old database_versions table
#2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
Nemo157
approved these changes
Jan 24, 2024
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is coming from this discussion on zulip.
When creating the new initial database migration in #2327 I mistakenly left the
database_versionstable in there.This lead to a confusing error message when a developer ran
cargo run -- database migratethe second time.Since we drop the
database_versionstable in our migration-flow from the old schemamama migrations to the new sqlx migrations, I think the correct solution is to fix the initial migration instead of adding another one.IMO the developers having this error locally should not be many, they could drop the table manually, or recreate their local database.