move builder temp-dir to prefix to avoid conflicts with second builder #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nemo157 |
github-actions
bot
added
the
S-waiting-on-review
Nemo157
reviewed
Oct 12, 2023
syphar
force-pushed
the
separate-build-temp-directories
branch
from
a0d9991 to
a6a5413
Compare
syphar
force-pushed
the
separate-build-temp-directories
branch
from
a6a5413 to
dc5749b
Compare
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in our builder we are using
tempfile::tempdirwith a prefix to store temporary files from the build.Due to how the
tempfilecrate works, this in itself won't lead to any issues when running multiple builders.But after #808 (and #1553 / #1586 ) we started cleaning directories with the same prefix, from both builders, which lead to silently deleting temporary files from other builders, and loudly failing when trying to cleanup ( see this sentry error).
This PR makes the tempdir a subdirectory of
Config.prefix, which IMO is easier to reason with.