Add API token creation notifications #9245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domodwyer
commented
Aug 10, 2024
domodwyer
force-pushed
the
dom/token-creation-email
branch
from
b77b774 to
83c8313
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9245 +/- ##
==========================================
+ Coverage 89.27% 89.29% +0.01%
==========================================
Files 282 282
Lines 28590 28629 +39
==========================================
+ Hits 25525 25563 +38
- Misses 3065 3066 +1 ☔ View full report in Codecov by Sentry. |
Turbo87
changed the title
Turbo87
reviewed
Aug 11, 2024
|
No worries! Go and enjoy vacation - this can definitely wait 🙏 |
Turbo87
added
C-enhancement ✨
When a new token is created for an account, send a notification email to the account owner.
Use "{domain}" instead of "crates.io" when describing where the token
was created.
Reduces the diff of the pull request since this is an unrelated change ;)
A little easier on the eyes :)
Turbo87
force-pushed
the
dom/token-creation-email
branch
from
91da220 to
4618f59
Compare
|
I've rebased and slightly tweaked it to include the token name in the notification email, but other than that this looks great. thanks again! :) |
Turbo87
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make crates.io email the user's registered email address when a new token is added to their account.
An email notification helps mitigate a sneaky 3rd party with access to the account from creating a token and using it to do nasty things later. Without the notification you'd only know about the token if you were periodically checking the token page.
Part of #2639
feat: token creation notification email (83c8313)