Remove r2d2 database connection pools
#8442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are not used anywhere anymore.
These functions are no longer used anywhere in our codebase.
These are no longer used anywhere in our codebase.
Turbo87
added
C-internal 🔧
LawnGnome
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completely removes the sync
r2d2database connection pools from our backend server code. All of our code has now been migrated to thedeadpoolasync pools.There is one small caveat: our
crates_io_test_dbpackage is still usingr2d2under the hood. If/How that can be migrated remains to be seen, since it's relying onDropimpls, which are complicated in an async world.