Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crate/delete: tinker with the requirements styling #10253

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

LawnGnome
Copy link
Contributor

@LawnGnome LawnGnome commented Dec 20, 2024

As discussed at today's team meeting, here is a slight tweak to how the requirements are laid out when deleting a crate.

Before:

image

After:

image

@LawnGnome LawnGnome added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-frontend 🐹 labels Dec 20, 2024
@LawnGnome LawnGnome self-assigned this Dec 20, 2024
@eth3lbert
Copy link
Contributor

I feel it would be better if the "OR" were left-aligned, perhaps placing it between "the" and "(a)". This is more of a personal preference, so I might be wrong 😉

@LawnGnome
Copy link
Contributor Author

@eth3lbert I don't know where I land on that — I think I want a little more visual hierarchy, but just centering might be admittedly too much. How about this:

image

@eth3lbert
Copy link
Contributor

@eth3lbert I don't know where I land on that — I think I want a little more visual hierarchy, but just centering might be admittedly too much. How about this:

image

This looks great to me! I love this one 😍

@Turbo87 Turbo87 force-pushed the tweak-delete-design branch from e574c44 to 6250112 Compare December 30, 2024 10:05
@Turbo87
Copy link
Member

Turbo87 commented Dec 30, 2024

rebased to fix the conflict with #10266

@Turbo87 Turbo87 enabled auto-merge December 30, 2024 10:05
@Turbo87 Turbo87 merged commit ef31905 into rust-lang:main Dec 30, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants