Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controllers/helpers/pagination: Remove generic parameter from gather() fn #10190

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 12, 2024

Ideally we'd only pass in a Uri, but since we're using the RequestLog we still need to pass in the full Parts struct.

Previously we were compiling two variants of this function, one for Parts and one for Request, although only our test code was still using the Request variant. This PR changes the tests to use Parts too and then removes the obsolete generic parameter from the gather() fn.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Dec 12, 2024
@Turbo87 Turbo87 enabled auto-merge (squash) December 12, 2024 16:04
@Turbo87 Turbo87 merged commit 9094938 into rust-lang:main Dec 12, 2024
8 checks passed
@Turbo87 Turbo87 deleted the generic-pagination branch December 12, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant