models/crate: Make owners getter rely on loadOwnersTask

This fixes the following deprecations:
- The toArray method on ember-data's PromiseManyArray is deprecated.
- The `toArray` method on the class ManyArray is deprecated.

by explicitly loading `owners` with a task.

app/models/crate.js

@@ -1,7 +1,10 @@
 import Model, { attr, hasMany } from '@ember-data/model';
+import { assert } from '@ember/debug';
 import { waitForPromise } from '@ember/test-waiters';
 import { cached } from '@glimmer/tracking';
 
+import { task } from 'ember-concurrency';
+
 import { apiAction } from '@mainmatter/ember-api-actions';
 
 export default class Crate extends Model {
@@ -66,9 +69,9 @@ export default class Crate extends Model {
   }
 
   get owners() {
-    let teams = this.owner_team.toArray() ?? [];
-    let users = this.owner_user.toArray() ?? [];
-    return [...teams, ...users];
+    let { last } = this.loadOwnersTask;
+    assert('`loadOwnersTask.perform()` must be called before accessing `owners`', last != null);
+    return last?.value ?? [];
   }
 
   async follow() {
@@ -100,6 +103,11 @@ export default class Crate extends Model {
       throw response;
     }
   }
+
+  loadOwnersTask = task(async () => {
+    let [teams, users] = await Promise.all([this.owner_team, this.owner_user]);
+    return [...(teams ?? []), ...(users ?? [])];
+  });
 }
 
 function compareVersionBySemver(a, b) {

app/routes/crate/version.js

@@ -53,6 +53,11 @@ export default class VersionRoute extends Route {
     });
 
     let { crate, version } = model;
+
+    waitForPromise(crate.loadOwnersTask.perform()).catch(() => {
+      // ignored
+    });
+
     if (!crate.documentation || crate.documentation.startsWith('https://docs.rs/')) {
       version.loadDocsStatusTask.perform().catch(error => {
         // report unexpected errors to Sentry and ignore `ajax()` errors

tests/components/crate-sidebar/playground-button-test.js

@@ -34,6 +34,7 @@ module('Component | CrateSidebar | Playground Button', function (hooks) {
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
     this.version = (await this.crate.versions).firstObject;
+    await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<CrateSidebar @crate={{this.crate}} @version={{this.version}} />`);
     assert.dom('[data-test-playground-button]').doesNotExist();
@@ -46,6 +47,7 @@ module('Component | CrateSidebar | Playground Button', function (hooks) {
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
     this.version = (await this.crate.versions).firstObject;
+    await this.crate.loadOwnersTask.perform();
 
     let expectedHref =
       'https://play.rust-lang.org/?edition=2021&code=use%20aho_corasick%3B%0A%0Afn%20main()%20%7B%0A%20%20%20%20%2F%2F%20try%20using%20the%20%60aho_corasick%60%20crate%20here%0A%7D';
@@ -64,6 +66,7 @@ module('Component | CrateSidebar | Playground Button', function (hooks) {
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
     this.version = (await this.crate.versions).firstObject;
+    await this.crate.loadOwnersTask.perform();
 
     render(hbs`<CrateSidebar @crate={{this.crate}} @version={{this.version}} />`);
     await waitFor('[data-test-owners]');
@@ -82,6 +85,7 @@ module('Component | CrateSidebar | Playground Button', function (hooks) {
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
     this.version = (await this.crate.versions).firstObject;
+    await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<CrateSidebar @crate={{this.crate}} @version={{this.version}} />`);
     assert.dom('[data-test-playground-button]').doesNotExist();

tests/components/crate-sidebar/toml-snippet-test.js

@@ -18,6 +18,7 @@ module('Component | CrateSidebar | toml snippet', function (hooks) {
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
     this.version = (await this.crate.versions).firstObject;
+    await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<CrateSidebar @crate={{this.crate}} @version={{this.version}} />`);
     assert.dom('[title="Copy command to clipboard"]').exists().hasText('cargo add foo');
@@ -35,6 +36,7 @@ module('Component | CrateSidebar | toml snippet', function (hooks) {
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
     this.version = (await this.crate.versions).firstObject;
+    await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<CrateSidebar @crate={{this.crate}} @version={{this.version}} />`);
     assert.dom('[title="Copy Cargo.toml snippet to clipboard"]').exists().hasText('foo = "1.0.0"');
@@ -47,6 +49,7 @@ module('Component | CrateSidebar | toml snippet', function (hooks) {
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
     this.version = (await this.crate.versions).firstObject;
+    await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<CrateSidebar @crate={{this.crate}} @version={{this.version}} />`);
     assert.dom('[title="Copy Cargo.toml snippet to clipboard"]').exists().hasText('foo = "1.0.0-alpha"');

tests/components/owners-list-test.js

@@ -20,8 +20,7 @@ module('Component | OwnersList', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
-    await this.crate.hasMany('owner_team').load();
-    await this.crate.hasMany('owner_user').load();
+    await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<OwnersList @owners={{this.crate.owners}} />`);
     assert.dom('[data-test-owners="detailed"]').exists();
@@ -44,8 +43,7 @@ module('Component | OwnersList', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
-    await this.crate.hasMany('owner_team').load();
-    await this.crate.hasMany('owner_user').load();
+    await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<OwnersList @owners={{this.crate.owners}} />`);
     assert.dom('[data-test-owners="detailed"]').exists();
@@ -70,8 +68,7 @@ module('Component | OwnersList', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
-    await this.crate.hasMany('owner_team').load();
-    await this.crate.hasMany('owner_user').load();
+    await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<OwnersList @owners={{this.crate.owners}} />`);
     assert.dom('[data-test-owners="detailed"]').exists();
@@ -93,8 +90,7 @@ module('Component | OwnersList', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
-    await this.crate.hasMany('owner_team').load();
-    await this.crate.hasMany('owner_user').load();
+    await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<OwnersList @owners={{this.crate.owners}} />`);
     assert.dom('[data-test-owners="basic"]').exists();
@@ -120,8 +116,7 @@ module('Component | OwnersList', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     this.crate = await store.findRecord('crate', crate.name);
-    await this.crate.hasMany('owner_team').load();
-    await this.crate.hasMany('owner_user').load();
+    await this.crate.loadOwnersTask.perform();
 
     await render(hbs`<OwnersList @owners={{this.crate.owners}} />`);
     assert.dom('[data-test-owners="detailed"]').exists();