add c_unwind feature #583
Merged
add c_unwind feature #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like macOS is unhappy, so we do need that patch after all I guess. |
|
Ah no, #582 isn't resolved yet. So likely unrelated. |
|
CI should be fixed now, can you rebase? |
|
Rebase done. CI looks good. :) |
|
FWIW this may have perf impacts so the rustc PR that bumps compiler-builtins to include this change should probably be rollup=never. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2024
update compiler_builtins to 0.1.109 This pulls in rust-lang/compiler-builtins#583 so we should make sure that does not come with any perf surprises. Cc `@Amanieu`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 13, 2024
…imulacrum update compiler_builtins to 0.1.109 This pulls in rust-lang/compiler-builtins#583 so we should make sure that does not come with any perf surprises. Cc `@Amanieu`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2024
…imulacrum update compiler_builtins to 0.1.109 This pulls in rust-lang/compiler-builtins#583 so we should make sure that does not come with any perf surprises. Cc `@Amanieu`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2024
…imulacrum update compiler_builtins to 0.1.109 This pulls in rust-lang/compiler-builtins#583 so we should make sure that does not come with any perf surprises. Cc `@Amanieu`
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Apr 15, 2024
update compiler_builtins to 0.1.109 This pulls in rust-lang/compiler-builtins#583 so we should make sure that does not come with any perf surprises. Cc `@Amanieu`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
c_unwindfeature is special in that just enabling the feature has a side-effect of treating allextern "C"functions different, in terms of how unwinding is handled. This crate has lots ofextern "C"functions and is very sensitive to unwinding (in the sense that no panic code may be called from this crate), so it seems like a good idea to ensure that compiler-builtins works with this feature before stabilizing (Cc rust-lang/rust#116088).So... let's see what all the extra checks in CI here say. This may require a patch like this, or maybe not.
Cc @nbdd0121