-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend push_auto_trait_impl to built-in types #612
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2a96aa3
Extend push_auto_trait_impl to a few built-in types
memoryleak47 e87aa6d
Fix test
memoryleak47 6bd2da5
Add `consistuent_types`
memoryleak47 85f93c9
Use flat_map(...) instead of map(...).flatten()
memoryleak47 ef0b55b
Typo
memoryleak47 4aa6430
Auto traits are not implemented for foreign types
memoryleak47 ee8fa77
Function types implement auto traits unconditionally
memoryleak47 40d4edc
Implement auto trait handling of closures
memoryleak47 0604b12
Update book
memoryleak47 fdfce1d
Add auto trait tests
memoryleak47 c613abd
Fix logging
memoryleak47 d8fe6bc
Cover PhantomData for auto traits
memoryleak47 17eb26e
Improve auto trait tests
memoryleak47 c35689c
Simplify edge-case handling
memoryleak47 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -217,3 +217,112 @@ fn enum_auto_trait() { | |
} | ||
} | ||
} | ||
|
||
#[test] | ||
fn builtin_auto_trait() { | ||
test! { | ||
program { | ||
#[auto] trait AutoTrait {} | ||
struct Struct {} | ||
enum Enum { Var1, Var2 } | ||
fn func(); | ||
|
||
struct Marker {} | ||
impl !AutoTrait for Marker {} | ||
|
||
closure good_closure(self, arg: Marker) -> Marker { i32 } | ||
closure bad_closure(self, arg: i32) -> i32 { Marker } | ||
|
||
extern type Ext; | ||
enum ExtEnum { GoodVariant, BadVariant(Ext) } | ||
} | ||
|
||
goal { | ||
(Struct, Marker): AutoTrait | ||
} | ||
yields { | ||
"No possible solution" | ||
} | ||
|
||
goal { | ||
forall<'a> { (fn(), [(); 1], [()], u32, *const (), str, !, Struct, Enum, func, good_closure, &'a ()): AutoTrait } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Mutable ref and raw please |
||
} | ||
yields { | ||
"Unique; substitution [], lifetime constraints []" | ||
} | ||
|
||
goal { | ||
good_closure: AutoTrait | ||
} | ||
yields { | ||
"Unique; substitution [], lifetime constraints []" | ||
} | ||
|
||
goal { | ||
bad_closure: AutoTrait | ||
} | ||
yields { | ||
"No possible solution" | ||
} | ||
|
||
goal { | ||
ExtEnum: AutoTrait | ||
} | ||
yields { | ||
"No possible solution" | ||
} | ||
} | ||
} | ||
|
||
#[test] | ||
fn adt_auto_trait() { | ||
test! { | ||
program { | ||
#[auto] trait AutoTrait {} | ||
struct Yes {} | ||
struct No {} | ||
impl !AutoTrait for No {} | ||
|
||
struct WrapperNo<T> { t: T } | ||
struct WrapperYes<T> { t: T } | ||
|
||
struct X {} | ||
impl !AutoTrait for WrapperNo<X> {} | ||
} | ||
|
||
goal { | ||
Yes: AutoTrait | ||
} | ||
yields { | ||
"Unique; substitution [], lifetime constraints []" | ||
} | ||
|
||
goal { | ||
No: AutoTrait | ||
} | ||
yields { | ||
"No possible solution" | ||
} | ||
|
||
goal { | ||
X: AutoTrait | ||
} | ||
yields { | ||
"Unique; substitution [], lifetime constraints []" | ||
} | ||
|
||
goal { | ||
WrapperNo<Yes>: AutoTrait | ||
} | ||
yields { | ||
"No possible solution" | ||
} | ||
|
||
goal { | ||
WrapperYes<No>: AutoTrait | ||
} | ||
yields { | ||
"No possible solution" | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments on these would be nice.
Can we also get a test of a tuple that does impl the auto trait.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, Haha, that's below.
Clever, but I would feel better about splitting it up a bit.