Adding parsing and AST->IR lowering for RevealMode + Overrides + added reveal { G } syntax #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I recommend excluding the rustfmt commit when you review this because it adds a lot of unnecessary noise. |
| @@ -214,7 +214,11 @@ fn program_clauses_that_could_match( | |||
| DomainGoal::LocalImplAllowed(trait_ref) => db | |||
| .trait_datum(trait_ref.trait_id) | |||
| .to_program_clauses(db, clauses), | |||
| DomainGoal::Compatible(()) => (), | |||
| DomainGoal::Compatible(()) | DomainGoal::RevealMode(()) => (), | |||
| DomainGoal::Overrides(ov) => { | |||
There was a problem hiding this comment.
So here we need to find all the "sources" of overrides clauses. I think these would derive from lowering the "assoc type values" found in impl of the given trait, so the simplest thing would be to call push_program_clauses_for_associated_type_values_in_impls_of like we do for Normalize.
…d reveal { G } syntax
|
There are conflicts now - so should be rebased. |
|
We discussed this in the meeting today (https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E14/near/193955431) and decided to close this. I'm gonna link this in a specialization-related issue for potential followup though |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This begins to implement the first bullet in #219 (comment).
I added a number of things:
reveal { G }syntax similar to thecompatible { G }syntax we already have for introducing theRevealMode(this is useful for testing and whatnot)RevealModeandOverrides[V0](P0: Trait<P1..Pn>)syntaxDebug,Fold,Zipstuff for the new variants and typesUnresolved questions for @nikomatsakis before this is merged:
Overridesin clauses.rs? Right now I've just left it asunimplemented!()LocalImplAllowedand create program clauses for the trait ref, but do we also have to take the associated type ID into account?I'm going to do the second part of this ("Modify the lowering for default type to include the
Overridesclause") after this PR.