Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the ability to parse 'default type Foo = Bar' when implementing a trait #221

Merged
merged 1 commit into from
May 4, 2019
Merged

Adding the ability to parse 'default type Foo = Bar' when implementing a trait #221

merged 1 commit into from
May 4, 2019

Conversation

sunjay
Copy link
Member

@sunjay sunjay commented May 3, 2019

Should be an easy to review PR. This implements the first step laid out by @nikomatsakis here: #219 (comment)

As @sunjay pointed out on Zulip, an obvious first step is:

Extend the parser to support default type Foo = Bar inside of an impl; that should be a flag on the associated type value.

@sunjay sunjay requested a review from nikomatsakis May 3, 2019 20:36
@sunjay
Copy link
Member Author

sunjay commented May 4, 2019

As expected from #220 this passes on stable but not nightly.

@nikomatsakis nikomatsakis merged commit 17fb07e into rust-lang:master May 4, 2019
@sunjay sunjay deleted the impl-default-type branch May 4, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunjay @nikomatsakis