Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some enhancements to cargo clean #12638

Merged
merged 9 commits into from
Sep 20, 2023
Merged

Add some enhancements to cargo clean #12638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
61e8ef3
Wrap clean operations in a CleanContext.
ehuss Sep 7, 2023
45c5394
Add a --dry-run option to `cargo clean`.
ehuss Sep 7, 2023
495ed7e
Add a summary to `cargo clean`.
ehuss Sep 7, 2023
e7e354c
Use existing arg_dry_run function.
ehuss Sep 7, 2023
e9110aa
Use `Self` type.
ehuss Sep 7, 2023
ebee726
Separately track files and directories removed.
ehuss Sep 10, 2023
f61d42d
Add a warning to `cargo clean --dry-run`
ehuss Sep 10, 2023
c204734
Don't display paths with `cargo clean --dry-run` without `--verbose`
ehuss Sep 10, 2023
655f75d
Add `cargo --dry-run` to the documentation.
ehuss Sep 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/cargo-test-support/src/compare.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ fn substitute_macros(input: &str) -> String {
("[UPDATING]", " Updating"),
("[ADDING]", " Adding"),
("[REMOVING]", " Removing"),
("[REMOVED]", " Removed"),
("[DOCTEST]", " Doc-tests"),
("[PACKAGING]", " Packaging"),
("[PACKAGED]", " Packaged"),
Expand Down
2 changes: 2 additions & 0 deletions src/bin/cargo/commands/clean.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ pub fn cli() -> Command {
.arg_target_triple("Target triple to clean output for")
.arg_target_dir()
.arg_manifest_path()
.arg_dry_run("Display what would be deleted without deleting anything")
.after_help(color_print::cstr!(
"Run `<cyan,bold>cargo help clean</>` for more detailed information.\n"
))
Expand All @@ -33,6 +34,7 @@ pub fn exec(config: &mut Config, args: &ArgMatches) -> CliResult {
requested_profile: args.get_profile_name(config, "dev", ProfileChecking::Custom)?,
profile_specified: args.contains_id("profile") || args.flag("release"),
doc: args.flag("doc"),
dry_run: args.dry_run(),
};
ops::clean(&ws, &opts)?;
Ok(())
Expand Down
Loading