ch16-05 - Add missing line in code example #3846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the output of the error shown in the following paragraph the `drop` statement should still be there, while it was removed from the listing src.
Now that the `drop` is back where it should be, tests fail because of the actual issue we're trying to showcase. Adding ignore to the markdown src.
chriskrycho
reviewed
Mar 27, 2024
There was a problem hiding this comment.
Thanks for the PR. However, I think you may have misunderstood what was going on here! Listing 16-5 shows the correct code for fixing listing 16-3, and then the text goes on to separately discuss whether it can fix listing 16-4 the same way, and the answer is no. I'm going to close this accordingly, but thank you again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the output of the error shown in the subsequent paragraph the
dropstatement should still be there, while it was removed from the listing src.