add support for fuzzing #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
force-pushed
the
fuzz-away
branch
3 times, most recently
from
12bf122 to
1c2b0a3
Compare
Still more work to do before we can productively use it. For example we always generate empty structs with no fields right now. But the setup seems correct.
lcnr
reviewed
Jul 12, 2024
There was a problem hiding this comment.
I've gotten slowly more unsure about that while going through this PR. If you have a homogeneous collection, their cardinality is cardinality_per_item^num_items, is it not 🤔
a bunch of nits, but the structure looks quite good, I like it. Especially the hackmd doc was very nice to read 😊
Comment on lines
+96
to
+98
| /// Lookup the value associated with the given value of type `K`. | ||
| /// If no map has been set for this (K,V) type, or if the key is not | ||
| /// found in the map that was set, returns `None`. |
Comment on lines
+254
to
+255
| /// Returns `None` if the recursion depth is exceeded. | ||
| /// Otherwise, returns a `Some(g)` with a guard that should be dropped when you have finished. |
Co-authored-by: lcnr <[email protected]>
Co-authored-by: lcnr <[email protected]>
Co-authored-by: lcnr <[email protected]>
Co-authored-by: lcnr <[email protected]>
Co-authored-by: lcnr <[email protected]>
Co-authored-by: lcnr <[email protected]>
Co-authored-by: lcnr <[email protected]>
Co-authored-by: lcnr <[email protected]>
Co-authored-by: lcnr <[email protected]>
Co-authored-by: lcnr <[email protected]>
Co-authored-by: lcnr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty crude. We generate garbage and we don't even run tests because it's not really good enough to be useful. But I figured the basic setup makes sense and we can adapt as we go. I'm interested in shifting gears to focus on stable-mir at the moment.