-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Q: ?Sized
in Itertools::contains
#971
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #971 +/- ##
==========================================
- Coverage 94.38% 94.32% -0.07%
==========================================
Files 48 49 +1
Lines 6665 6708 +43
==========================================
+ Hits 6291 6327 +36
- Misses 374 381 +7 ☔ View full report in Codecov by Sentry. |
phimuemue
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
facebook-github-bot
pushed a commit
to facebookincubator/below
that referenced
this pull request
Jan 2, 2025
Summary: [Changes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md) to be aware of, with [971](rust-itertools/itertools#971) as my favourite: {F1974159737} Differential Revision: D67751950 fbshipit-source-id: d5e39b7c685840b40aa7ba1b5015e8ccaea32b72
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Jan 2, 2025
Summary: [Changes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md) to be aware of, with [971](rust-itertools/itertools#971) as my favourite: {F1974159737} Differential Revision: D67751950 fbshipit-source-id: d5e39b7c685840b40aa7ba1b5015e8ccaea32b72
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Jan 2, 2025
Summary: [Changes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md) to be aware of, with [971](rust-itertools/itertools#971) as my favourite: {F1974159737} Differential Revision: D67751950 fbshipit-source-id: d5e39b7c685840b40aa7ba1b5015e8ccaea32b72
facebook-github-bot
pushed a commit
to facebookincubator/reindeer
that referenced
this pull request
Jan 2, 2025
Summary: [Changes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md) to be aware of, with [971](rust-itertools/itertools#971) as my favourite: {F1974159737} Differential Revision: D67751950 fbshipit-source-id: d5e39b7c685840b40aa7ba1b5015e8ccaea32b72
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Jan 2, 2025
Summary: [Changes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md) to be aware of, with [971](rust-itertools/itertools#971) as my favourite: {F1974159737} Differential Revision: D67751950 fbshipit-source-id: d5e39b7c685840b40aa7ba1b5015e8ccaea32b72
facebook-github-bot
pushed a commit
to facebook/errpy
that referenced
this pull request
Jan 2, 2025
Summary: [Changes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md) to be aware of, with [971](rust-itertools/itertools#971) as my favourite: {F1974159737} Differential Revision: D67751950 fbshipit-source-id: d5e39b7c685840b40aa7ba1b5015e8ccaea32b72
facebook-github-bot
pushed a commit
to facebook/pyre-check
that referenced
this pull request
Jan 2, 2025
Summary: [Changes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md) to be aware of, with [971](rust-itertools/itertools#971) as my favourite: {F1974159737} Differential Revision: D67751950 fbshipit-source-id: d5e39b7c685840b40aa7ba1b5015e8ccaea32b72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable
.contains("foo")
on anIterator<Item = String>
and similar