Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated_in_future lint #877

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

Philippe-Cholet
Copy link
Member

@Philippe-Cholet Philippe-Cholet commented Feb 13, 2024

I was wondering if we should remove some deprecated parts when I encountered the lint deprecated_in_future.

usize::MAX is stable since 1.43.0. Our MSRV is 1.43.1 so this is fine and the module std::usize and usize::max_value both say "Deprecating in a future version" so I remove those.

@Philippe-Cholet Philippe-Cholet added this to the next milestone Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6814180) 94.38% compared to head (c84709e) 94.30%.
Report is 8 commits behind head on master.

Files Patch % Lines
src/sources.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #877      +/-   ##
==========================================
- Coverage   94.38%   94.30%   -0.09%     
==========================================
  Files          48       48              
  Lines        6665     6672       +7     
==========================================
+ Hits         6291     6292       +1     
- Misses        374      380       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Philippe-Cholet Philippe-Cholet changed the title Deprecated in future: use usize::MAX instead Fix deprecated_in_future lint Feb 13, 2024
@Philippe-Cholet Philippe-Cholet added this pull request to the merge queue Feb 13, 2024
Merged via the queue into rust-itertools:master with commit 762643f Feb 13, 2024
12 of 13 checks passed
@Philippe-Cholet Philippe-Cholet deleted the deprecated branch February 13, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants