Deprecate unfold for std::iter::from_fn
#871
Merged
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #871 +/- ##
==========================================
- Coverage 94.38% 94.25% -0.14%
==========================================
Files 48 48
Lines 6665 6666 +1
==========================================
- Hits 6291 6283 -8
- Misses 374 383 +9 ☔ View full report in Codecov by Sentry. |
|
"semver checks" first failed in CI, I therefore updated the version to "0.13.0". |
Philippe-Cholet
force-pushed
the
deprecate-unfold-for-from_fn
branch
from
db47289 to
777b341
Compare
jswrenn
approved these changes
Feb 8, 2024
|
@jswrenn Yes after some PRs of mine that resolved old issues and closed a few PRs and some (I think reasonable) triage, we finally have less than 100 issues and 30 PRs. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #223. Based on #610 (comment) that suggested to add a deprecation notice instead of removing it directly.