Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZipLongest::fold: use try_fold? #854

Merged
merged 1 commit into from
Jan 18, 2024
Merged

ZipLongest::fold: use try_fold? #854

merged 1 commit into from
Jan 18, 2024

Conversation

Philippe-Cholet
Copy link
Member

Based on #849 (comment), ZipLongest::fold seems to be the only iterator that might benefit from this idea.

Benchmark specializations on slices is now +13% (still better than no fold specialization) but it might perform better in a more general case.

phimuemue
phimuemue approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@phimuemue phimuemue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Philippe-Cholet Philippe-Cholet added this to the next milestone Jan 17, 2024
@Philippe-Cholet Philippe-Cholet added this pull request to the merge queue Jan 18, 2024
Merged via the queue into rust-itertools:master with commit 6c588cd Jan 18, 2024
9 checks passed
@Philippe-Cholet Philippe-Cholet deleted the fold-zip-longest branch January 18, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phimuemue phimuemue phimuemue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Philippe-Cholet @phimuemue