Add "[must-use]" attribute into collect vec #1009
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might lead to the problems as following:
This code has a typo and rust warns against it:
If you replace it with following:
No warning will be generated, as no
must_use
attribute exist on the function.This PR adds it, while small, it can lead to huge problems, since
()
implements a lot of traits andimpl Trait
are used very often with iterators, so you can erroneously use one instead of another.P.S. I also noticed that
try_collect
only works with#[cfg(feature = "use_alloc")]
, buttry_collect
doesn't. I'm not sure if this is intended.