zip_squash & zip_stretch
#1004
Open
zip_squash & zip_stretch
#1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswrenn
reviewed
Dec 14, 2024
src/lib.rs
Outdated
Comment on lines
4565
to
4569
| fn zip_squash<J>(self, other: J) -> ZipSquash<Self, J::IntoIter> | ||
| where | ||
| J: IntoIterator, | ||
| <J as IntoIterator>::IntoIter: ExactSizeIterator, | ||
| Self: Sized; |
There was a problem hiding this comment.
Couldn't this method just be on Itertools with a Self: ExactSizeIterator bound? Why introduce a new trait?
There was a problem hiding this comment.
Oh yeah I can do that. Updated to do that.
JonathanWoollett-Light
force-pushed
the
ExactSizeItertools
branch
2 times, most recently
from
1130e46 to
fe3c505
Compare
JonathanWoollett-Light
changed the title
ExactSizeItertoolszip_squash & zip_stretch
JonathanWoollett-Light
force-pushed
the
ExactSizeItertools
branch
2 times, most recently
from
5e80e7c to
0e2f859
Compare
Introduces new zip alternatives.
JonathanWoollett-Light
force-pushed
the
ExactSizeItertools
branch
from
0e2f859 to
b065292
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces new zip alternatives.
I was making an application that uses something like
zip_squashand thought it could be implemented here.Examples might be forming pairs from 2 sets of data where you want one-to-one relationships with
zip_squashor sets where you want all points to have a pair and want many-to-one relationships withzip_stretch.