-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example of opaque CountDown type usage #109
Open
thenewwazoo
wants to merge
3
commits into
rust-embedded:master
Choose a base branch
from
thenewwazoo:countdown-doc-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add example of opaque CountDown type usage #109
thenewwazoo
wants to merge
3
commits into
rust-embedded:master
from
thenewwazoo:countdown-doc-update
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thenewwazoo
requested review from
ilya-epifanov,
thejpster and
a team
as code owners
November 7, 2018 17:27
therealprof
reviewed
Nov 7, 2018
thenewwazoo
force-pushed
the
countdown-doc-update
branch
from
November 8, 2018 04:51
0a38a9c
to
9a84bdb
Compare
Got rid of the .gitignore line, should be gtg. |
therealprof
reviewed
Nov 8, 2018
Co-Authored-By: thenewwazoo <[email protected]>
therealprof
approved these changes
Nov 8, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
therealprof
requested changes
Nov 8, 2018
bors retry |
mathk
added
S-waiting-on-author
Author needs to make changes to address reviewer comments
and removed
S-waiting-on-author
Author needs to make changes to address reviewer comments
labels
Feb 25, 2019
bors try |
tryBuild succeeded |
mathk
added
the
S-waiting-on-author
Author needs to make changes to address reviewer comments
label
Feb 25, 2019
mathk
added
S-waiting-on-review
Review is incomplete
and removed
S-waiting-on-author
Author needs to make changes to address reviewer comments
labels
Feb 25, 2019
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a small doc update to illustrate how to permit using the
start
function of the CountDown trait when writing a driver.