Allow opaque enums #743
Merged
Allow opaque enums #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
Dec 9, 2024
|
merge conflicts, but then feel free to merge once CI is green |
emarteca
force-pushed
the
allow_opaque_enums
branch
from
e1480e7 to
7f59c05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for marking enums as
diplomat::opaque.Most of the changes are creating a general
OpaqueTypestructure instead of usingOpaqueStruct-- there was nothing specific to structs in theOpaqueStructimplementation. Also moved this new type to a new file since I don't think it logically fits in thestructsmodule anymore.Also added some tests.
#740