Fix primitive slice js (#722)

* fix-primitive-slice-js

* remove bench code

* gen example js

* fix primitive slice test

* Update feature_tests/js/test/slices.mjs

Co-authored-by: Tyler K <[email protected]>

---------

Co-authored-by: Manish Goregaokar <[email protected]>
Co-authored-by: Tyler K <[email protected]>

feature_tests/js/test/slices-ts.mjs

@@ -1,5 +1,5 @@
-import test from 'ava';
-import { MyString } from "diplomat-wasm-js-feature-tests";
+import test from "ava";
+import { MyString, Float64Vec } from "diplomat-wasm-js-feature-tests";
 test("MyString functionality", (t) => {
     let str = MyString.new_("This is a test value.");
     t.is(str.str, "This is a test value.");
@@ -8,3 +8,8 @@ test("String List", (t) => {
     let str = MyString.newFromFirst(["This", "is", "a", "test."]);
     t.is(str.str, "This");
 });
+test("Float64Vec", (t) => {
+    let input = [1, 2, 3, 4, 5];
+    let data = Float64Vec.newIsize(input);
+    t.deepEqual(data.borrow(), input);
+});

feature_tests/js/test/slices-ts.mts

@@ -1,12 +1,19 @@
-import test from 'ava';
-import { MyString } from "diplomat-wasm-js-feature-tests";
+import test from "ava";
+import { MyString, Float64Vec } from "diplomat-wasm-js-feature-tests";
+import wasm from "../api/diplomat-wasm.mjs";
 
 test("MyString functionality", (t) => {
-    let str = MyString.new_("This is a test value.");
-    t.is(str.str, "This is a test value.");
+  let str = MyString.new_("This is a test value.");
+  t.is(str.str, "This is a test value.");
 });
 
 test("String List", (t) => {
-	let str = MyString.newFromFirst(["This", "is", "a", "test."]);
-	t.is(str.str, "This");
-});
+  let str = MyString.newFromFirst(["This", "is", "a", "test."]);
+  t.is(str.str, "This");
+});
+
+test("Float64Vec", (t) => {
+  let input = [1, 2, 3, 4, 5];
+  let data = Float64Vec.newIsize(input);
+  t.deepEqual(data.borrow(), input);
+});

feature_tests/js/test/slices.mjs

@@ -1,5 +1,5 @@
 import test from 'ava';
-import { MyString } from "diplomat-wasm-js-feature-tests";
+import { MyString, Float64Vec} from "diplomat-wasm-js-feature-tests";
 
 test("MyString functionality", (t) => {
     let str = MyString.new_("This is a test value.");
@@ -9,4 +9,10 @@ test("MyString functionality", (t) => {
 test("String List", (t) => {
 	let str = MyString.newFromFirst(["This", "is", "a", "test."]);
 	t.is(str.str, "This");
-});
+});
+
+test("Float64Vec", (t) => {
+    let input = [1, 2, 3, 4, 5];
+    let data = Float64Vec.newIsize(input);
+    t.deepEqual(data.borrow(), input);
+});

tool/src/js/converter.rs

@@ -239,7 +239,7 @@ impl<'jsctx, 'tcx> TyGenContext<'jsctx, 'tcx> {
                 // Slices are always returned to us by way of pointers, so we assume that we can just access DiplomatReceiveBuf's helper functions:
                 match slice {
                     hir::Slice::Primitive(_, primitive_type) => format!(
-                        r#"new diplomatRuntime.DiplomatSlicePrimitive.getSlice(wasm, {variable_name}, "{}", {edges})"#,
+                        r#"Array.from(new diplomatRuntime.DiplomatSlicePrimitive(wasm, {variable_name}, "{}", {edges}).getValue())"#,
                         self.formatter.fmt_primitive_list_view(primitive_type)
                     )
                     .into(),

tool/templates/js/runtime.mjs

@@ -606,4 +606,4 @@ export class GarbageCollectorGrip {
     }
 }
 
-const DiplomatBufferFinalizer = new FinalizationRegistry(free => free());
+const DiplomatBufferFinalizer = new FinalizationRegistry(free => free());