Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test bitcoin #72

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Test bitcoin #72

wants to merge 5 commits into from

Commits on Apr 7, 2024

  1. Remove path dev-dependency 

    Currently we are enabling "rand" using a path dependency in the
dev-dependencies because of the benches. This is reducing coverage in CI
because "std" is always enabled.

Feature gate the bench that requires "rand" and remove the path
dependency.
    @tcharding
    tcharding committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    ec2a2cc View commit details
    Browse the repository at this point in the history

  2. This should be PR 69

    @tcharding
    tcharding committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    e7bad94 View commit details
    Browse the repository at this point in the history

  3. Merge branch '04-08-bench-rand-dev-dep' into test-bitcoin

    @tcharding
    tcharding committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    3186df1 View commit details
    Browse the repository at this point in the history

  4. Document MSRV effect of different versions of hashes 

    We use a range dependency for `bitcoin_hashes`, the different allowed
versions each have a different MSRV, which implies using each changes
the MSRV of `bip39`.
    @tcharding
    tcharding committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    93d3484 View commit details
    Browse the repository at this point in the history

  5. Add hashes 0.14 to the dependency range 

    We just release a new version of `bitcoin_hashes` which works with
`bip39` with no changes.

Add `bitcoin_hashes v0.14` to the dependency range and document its
effect on the MSRV.

(Note, the "alloc" feature is required as of 0.14).
    @tcharding
    tcharding committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    af383fb View commit details
    Browse the repository at this point in the history