Skip to content

Commit

Permalink
Enable bitcoin_hashes v0.14.0
Browse files Browse the repository at this point in the history
Hardware devices like the smallest binary possible, currently if one
builds with latest `rust-bitcoin` and `rust-bip39` they get two versions
of `bitcoin_hashes` in the dependency graph because we don't support the
latest `bitcoin_hashes`.

We use a range dependency for `bitcoin_hashes`. We can support the
latest version with no code changes. However using the latest version
causes the MSRV to increase.

Add the latest version of `bitcoin_hashes` to the range dependency.
  • Loading branch information
tcharding committed Jul 30, 2024
1 parent b100bf3 commit 46ef0ed
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,13 @@ serde = { version = "1.0", default-features = false, features = [ "alloc" ], opt
zeroize = { version = "1.5", features = ["zeroize_derive"], optional = true }

# Unexported dependnecies
bitcoin_hashes = { version = ">=0.12, <=0.13", default-features = false }
bitcoin_hashes = { version = ">=0.12, <=0.14", default-features = false }
unicode-normalization = { version = "=0.1.22", default-features = false, optional = true }

[dev-dependencies]
# Enabling the "rand" feature by default to run the benches
bip39 = { path = ".", features = ["rand"] }
bitcoin_hashes = ">=0.12,<0.14" # enable default features for test
bitcoin_hashes = ">=0.12,<=0.14" # enable default features for test


[package.metadata.docs.rs]
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ Use the `all-languages` feature to enable all languages.

This crate supports Rust v1.41.1 and up and works with `no_std`.

Using `bitcoin_hashes v0.14.0` raises the MSRV to `1.56.1`.

When using older version of Rust, you might have to pin the version of the
`bitcoin_hashes` crate used as such:
```
Expand Down

0 comments on commit 46ef0ed

Please sign in to comment.