Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add V1 fallback mode to the proxy #83

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

nyonson
Copy link
Collaborator

@nyonson nyonson commented Oct 22, 2024

Adding the flag --v1-fallback to enable falling back to the V1 protocol if the remote doesn't support V2.

Deprecates the old v1 binary of the proxy app. This was only used for our own tests and doesn't serve much of a purpose now. The logic was folded into the remaining proxy app.

Closes #27

@nyonson nyonson requested a review from rustaceanrob October 22, 2024 22:18
@nyonson
Copy link
Collaborator Author

nyonson commented Oct 22, 2024

@Kixunil does configure_me support bool flags where you don't have to give an argument? For example, I am passing --v1-fallback=true, but would be nice to just set --v1-fallback.

@rustaceanrob
Copy link
Collaborator

ACK 49a4d98

@rustaceanrob
Copy link
Collaborator

Let's get this is in and we can improve the CLI arg if possible later

@rustaceanrob rustaceanrob merged commit fc94b9a into rust-bitcoin:main Oct 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for fallback to v1 in proxy
2 participants